Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove prettier override so editorconfig is applied #360

Merged
merged 1 commit into from
May 1, 2023

Conversation

andrewiggins
Copy link
Member

We had useTabs: true in our prettier config which overrode our .editorconfig to use spaces in json files. I've removed the useTabs in the package.json prettier config so .editorconfig is used instead. I've also reformatted all the code so it's consistent.

@changeset-bot
Copy link

changeset-bot bot commented May 1, 2023

⚠️ No Changeset found

Latest commit: 7ef9bdf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented May 1, 2023

Deploy Preview for preact-signals-demo ready!

Name Link
🔨 Latest commit 7ef9bdf
🔍 Latest deploy log https://app.netlify.com/sites/preact-signals-demo/deploys/645045c05f560100076001c8
😎 Deploy Preview https://deploy-preview-360--preact-signals-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link
Contributor

github-actions bot commented May 1, 2023

Size Change: 0 B

Total Size: 68.9 kB

ℹ️ View Unchanged
Filename Size
docs/dist/assets/client.********.js 46.5 kB
docs/dist/assets/index.********.js 835 B
docs/dist/assets/jsxRuntime.module.********.js 282 B
docs/dist/assets/preact.module.********.js 4 kB
docs/dist/assets/signals-core.module.********.js 1.42 kB
docs/dist/assets/signals.module.********.js 1.97 kB
docs/dist/assets/style.********.js 21 B
docs/dist/assets/style.********.css 1.21 kB
docs/dist/basic-********.js 244 B
docs/dist/demos-********.js 3.35 kB
docs/dist/nesting-********.js 1.13 kB
docs/dist/react-********.js 237 B
packages/core/dist/signals-core.js 1.48 kB
packages/core/dist/signals-core.mjs 1.5 kB
packages/preact/dist/signals.js 1.2 kB
packages/preact/dist/signals.mjs 1.15 kB
packages/react/dist/signals.js 1.21 kB
packages/react/dist/signals.mjs 1.15 kB

compressed-size-action

@andrewiggins andrewiggins merged commit 6959e94 into main May 1, 2023
@andrewiggins andrewiggins deleted the prettier-format branch May 1, 2023 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants